Skip to content

[DERCBOT-1365] Fix CSV headers#1847

Merged
Benvii merged 1 commit intotheopenconversationkit:masterfrom
CreditMutuelArkea:fix/dercbot-1365
Feb 14, 2025
Merged

[DERCBOT-1365] Fix CSV headers#1847
Benvii merged 1 commit intotheopenconversationkit:masterfrom
CreditMutuelArkea:fix/dercbot-1365

Conversation

@assouktim
Copy link
Copy Markdown
Contributor

@assouktim assouktim commented Feb 13, 2025

This pull request includes changes to the smarttribune_consumer.py file to standardize column naming conventions and improve consistency across the data processing functions. The most important changes include renaming columns and updating references to these columns in various functions.

Column renaming and updates:

  • async def _get_question(token, row, current_page): Renamed columns from 'Title' to 'title' and 'URL' to 'source', and updated references accordingly.
  • async def _get_answer(token, row): Renamed columns from 'Title' to 'title', 'URL' to 'source', and 'Text' to 'text', and updated references accordingly.
  • async def _main(args, body_credentials): Updated references to the 'URL' column to 'source' for consistency.

@assouktim assouktim added the bug label Feb 13, 2025
@assouktim assouktim self-assigned this Feb 13, 2025
Copy link
Copy Markdown
Member

@Benvii Benvii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix

@scezen scezen self-requested a review February 14, 2025 14:31
@Benvii Benvii merged commit 9b18e31 into theopenconversationkit:master Feb 14, 2025
@Benvii Benvii deleted the fix/dercbot-1365 branch February 14, 2025 14:43
@vsct-jburet vsct-jburet modified the milestones: 24.9.8, 24.9.7 Feb 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

4 participants