[DERCBOT-1374] Public URL for Langfuse Observability Settings#1856
Merged
Benvii merged 6 commits intotheopenconversationkit:masterfrom Mar 27, 2025
Conversation
2f1f3f2 to
0611d9e
Compare
7d54ad9 to
b94864d
Compare
assouktim
requested changes
Mar 19, 2025
Contributor
assouktim
left a comment
There was a problem hiding this comment.
Thanks for your code, it just needs a few adjustments.
...strator-server/src/main/python/server/src/gen_ai_orchestrator/routers/responses/responses.py
Outdated
Show resolved
Hide resolved
Benvii
requested changes
Mar 27, 2025
Member
Benvii
left a comment
There was a problem hiding this comment.
Ok but needs to remove it from python side as it's not used
| url: AnyUrl = Field( | ||
| description='The Langfuse server url', examples=['https://cloud.langfuse.com'], default='http://localhost:3000' | ||
| ) | ||
| public_url: Optional[AnyUrl] = Field( |
Member
There was a problem hiding this comment.
Why do you have a public URL here as it's not used in the orchestrator.
Member
There was a problem hiding this comment.
I see we share the same data model between the orchestrator and the bot admin BotObservabilityConfigurationDTO.setting is LangfuseObservabilitySetting which came from the Orchestrator API contract we should have a BotAdmin API contract decorrelated from the ochestrator contract to avoid this.
f73351e to
e5a2f62
Compare
Benvii
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket : DERCBOT-1374
This PR introduces a new optionnal attribute for the Observability Settings :
If filled, the traceUrl of
ObservabilityInfowill get replaced by the public URL as so :