[Tock Studio] Add time precision, feedback display, and filtering for Custom Metrics & Dialogs (dercbot 1756 1763 1765)#1967
Merged
zigzago merged 3 commits intotheopenconversationkit:masterfrom Jan 8, 2026
Conversation
rkuffer
force-pushed
the
feature/dercbot-1756-1763-feedback-in-studio
branch
3 times, most recently
from
a2bdd3e to
af80262
Compare
assouktim
force-pushed
the
feature/dercbot-1756-1763-feedback-in-studio
branch
from
af80262 to
ffeaac6
Compare
…te and time filters # Conflicts: # bot/admin/web/src/app/metrics/metrics-board/metrics-board.component.html # bot/admin/web/src/app/metrics/metrics-board/metrics-board.component.ts
assouktim
force-pushed
the
feature/dercbot-1756-1763-feedback-in-studio
branch
from
ffeaac6 to
953a291
Compare
vsct-jburet
approved these changes
Jan 5, 2026
Contributor
|
@rkuffer I add copilot review. You can close all useless comments ;) |
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive feedback tracking and time precision features to Tock Studio's Custom Metrics and Dialogs views. The implementation introduces hour/minute granularity for date filters, visual feedback indicators for user-rated messages, aggregated feedback statistics in the metrics dashboard, and a feedback filter for dialogs.
Key changes:
- Replaced
NbDatepickerwithNbTimepickerfor hour/minute precision in date filters - Migrated metrics-board component to use Angular signals for reactive state management
- Added feedback display icons (thumbs up/down) across dialog views
- Extended dialog data model to support feedback metadata
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
.pre-commit-config.yaml |
Updated pip-audit dependencies and formatting |
gen-ai/orchestrator-server/.../pre-commit-config.yaml |
Generalized Python version from 3.9 to 3 |
bot/admin/web/.../testing.module.ts |
Removed unused NbEvaIconsModule import |
bot/admin/web/.../test-shared.module.ts |
Removed unused NbEvaIconsModule import |
bot/admin/web/.../utils.ts |
Added roundMinutesToNextTen utility function |
bot/admin/web/.../dialog-data.ts |
Added FeedbackParams interface and feedback fields to model |
bot/admin/web/.../sentence-training.component.spec.ts |
Updated and expanded test coverage for sentence training |
bot/admin/web/.../sentence-training-filters.component.spec.ts |
Removed obsolete tests for deleted clearSearch method |
bot/admin/web/.../chat-ui-dialog-logger.component.* |
Added feedback icon display for messages |
bot/admin/web/.../metrics.module.ts |
Added NbTimepickerModule for time precision |
bot/admin/web/.../metrics-board.component.* |
Refactored to use signals, added time precision and feedback stats |
bot/admin/web/.../analytics.module.ts |
Added NbTimepickerModule for time precision |
bot/admin/web/.../dialogs.ts |
Added FeedbackVote enum and feedback parameter to queries |
bot/admin/web/.../dialogs-list.component.ts |
Updated to pass feedback filter to backend |
bot/admin/web/.../dialogs-list-filters.component.* |
Added feedback filter UI with debounce optimization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bot/admin/web/src/app/metrics/metrics-board/metrics-board.component.html
Outdated
Show resolved
Hide resolved
...rc/app/analytics/dialogs/dialogs-list/dialogs-list-filters/dialogs-list-filters.component.ts
Show resolved
Hide resolved
...rc/app/analytics/dialogs/dialogs-list/dialogs-list-filters/dialogs-list-filters.component.ts
Show resolved
Hide resolved
bot/admin/web/src/app/metrics/metrics-board/metrics-board.component.html
Outdated
Show resolved
Hide resolved
bot/admin/web/src/app/metrics/metrics-board/metrics-board.component.ts
Outdated
Show resolved
Hide resolved
Member
Author
|
Copilot review taken into account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works with #1963
Closes #1965
This PR addresses the limitations described in Issue #1965 by introducing the following improvements:
1. Time Precision in Date Filters
YYYY-MM-DD HH:MM).2. Display Message Feedback in Dialog Component
3. Display Feedback Statistics in Custom Metrics View
4. Filter by Feedback in Dialogs View