Merged
Conversation
Contributor
Author
|
@eean I hope this still would work for you since you originally made the |
Collaborator
|
I don't know CMake very well, but these changes look reasonable to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever I wanted to make changes to HDC patch, I had to save it as a patch and let cmake recompile it.
INSTALLED_FAAD_IS_PATCHEDoption has made it easier. Currently, it assumes that the linker will find faad_hdc. I cannot provide a location if the linker cannot find it.You would normally provide a cmake find module file. Currently nrsc5's cmake relies on only pkgconfig. I think switching to cmake find module files would be a separate PR I think.