Open
Conversation
Collaborator
Author
|
@TheDaChicken noticed two issues:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429.
In general, libnrsc5 reports events only when the corresponding data values change. This avoids burdening applications with duplicate events, and cuts down on the amount of information that the command-line applications log.
But until now, ID3 events did not get this treatment. Every ID3 tag in the PSD stream was reported, even if it was the same as the last one. In some cases, multiple events were reported back-to-back because a single PDU can contain multiple ID3 tags.
Here I've changed libnrsc5 so that it only reports ID3 events when the PSD data changes. This roughly halves the amount of information logged by the command-line applications.