Closed
Conversation
Signed-off-by: Reece Dunham <me@rdil.rocks>
Contributor
|
Some inventory sets are exclusive (non-vanilla) too - this PR is for exclusive content so I put it here. |
Yanrishatum
approved these changes
Nov 20, 2024
Contributor
Yanrishatum
left a comment
Yanrishatum
left a comment
There was a problem hiding this comment.
Apart from the need to update a few challenges that do not bear the peacock tag despite being Peacock challenges (example is Rocco escalation challenge) - seems good to me.
AnthonyFuller
requested changes
Nov 20, 2024
Contributor
AnthonyFuller
left a comment
AnthonyFuller
left a comment
There was a problem hiding this comment.
Blocking from merging, I have a plan.
Contributor
|
duplication of #644 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Add toggle for Peacock exclusive content
Currently only works for challenges, as we don't really have a good way of telling what's a Peacock-exclusive contract, but that can be added as a follow-up.
Test Plan
Peacock exclusive challenges do not appear, but others do
Checklist