Open
Conversation
Two big changes here: 1. inventory is a class now, so the stateful parts are not stored on a module level 2. controller instance can be overridden for tests, so that code which hasn't yet been migrated to the IoC model can use the intended controller instance.
alex73630
approved these changes
Mar 24, 2026
Contributor
alex73630
left a comment
There was a problem hiding this comment.
Overall LGTM
Of course it would be better to have it checked against tests but I know that this change is required to get tests running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Two big changes here:
Test Plan
Checklist
General
Testing