feat: allow for authenticating Steam users without official#679
Draft
AnthonyFuller wants to merge 1 commit intomasterfrom
Draft
feat: allow for authenticating Steam users without official#679AnthonyFuller wants to merge 1 commit intomasterfrom
AnthonyFuller wants to merge 1 commit intomasterfrom
Conversation
…ctly using the app ticket
AnthonyFuller
force-pushed
the
tony/steam-auth
branch
from
a54a41b to
0e07a0d
Compare
Contributor
Author
|
Not a clue as to why merging from master causes esbuild to start failing... |
Member
|
Looks good from a quick glance, but I don't see why you would hash the ownership ticket; isn't Map already implemented as a hash map internally? |
Contributor
Author
|
It is, the hash is more for a reference for when RDIL does the backend implementation so he knows what to hash. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As title. Validates using the app ticket.
Pretty much done aside from the backend implementation (and final polish).