Use wget instead of curl#13
Draft
VolkerSchlegel wants to merge 1 commit intothepeacockproject:masterfrom
Draft
Conversation
A few people have had issues with the script not working at all due to an unstable network connection, wget should be more reliable in those circumstances
Author
|
Maybe still has issues |
Member
|
can we fall back to curl if wget isn't installed? |
Contributor
|
The main issue from using wget instead of curl is the fact that wget is not installed by default in a lot of cases compared to curl. So I agree with RDIL that we need a fallback if wget is not available. And maybe we can also add a "retry" mechanism to curl to help with connectivity issues? |
Author
|
Hm, didn't think that wget would be any rarer than curl, but yeah, a fallback would be good then and we absolutely need some way to better detect failed/corrupted downloads to retry in that case. |
Contributor
|
Added this feature in #14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few people have had issues with the script not working at all due to an unstable network connection, wget should be more reliable in those circumstances.