Fix PHP 8.5 deprecation: null as array offset in isArgument()#210
Open
hmennen90 wants to merge 1 commit intothephpleague:mainfrom
Open
Fix PHP 8.5 deprecation: null as array offset in isArgument()#210hmennen90 wants to merge 1 commit intothephpleague:mainfrom
hmennen90 wants to merge 1 commit intothephpleague:mainfrom
Conversation
prefix() and longPrefix() can return null, which was used as an array key. PHP 8.5 deprecates using null as an array offset. Refactored to check each prefix individually with explicit null guards instead of building an array with potentially null keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PHP 8.5 deprecates using
nullas an array offset.Argument::prefix()andArgument::longPrefix()can returnnull, which was used as array keys inManager::isArgument():Fix
Refactored
isArgument()to check each prefix individually with explicit null guards instead of building an array with potentially null keys. The behavior is unchanged — null prefixes are skipped.