Add standard getCreateToken/setCreateToken request methods #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leith
force-pushed
the
add-create-token-support
branch
from
991a9ac to
d792023
Compare
|
The CI failure message is:
This seems to be unrelated to the branch - higher versions of PHP (8.1+) are using newer versions of PHPUnit, which have a different XML configuration format. I've made a separate PR (#276) to fix the CI pipeline in case that's needed before this can be evaluated. |
leith
force-pushed
the
add-create-token-support
branch
from
d792023 to
0b1a1d3
Compare
|
With #276 now merged, CI is running and all passing as well. 👍 |
|
@judgej since this is largely based on your work on the sagepay driver, what do you think about making this a common flag? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most payment processors seem to have a "please store my card details" feature, where they pass back a token to the merchant to represent the card. We already have standard
getToken()andgetCardReference()methods for this parameter if it exists to pass along instead of card details, but no standard method for indicating that the token should be created as a part of the request in the first place.Usually this means it ends up as an implementation detail with whatever the parameter is called (tokenize, tokenMode, storeCard, etc.) and is one more detail that must be accounted for per-processor rather than something that can be relied on at a higher level to be a consistent flag.
This PR standardizes that flag as
getCreateToken()andsetCreateToken()(the same as https://github.com/thephpleague/omnipay-sagepay/) so we can reliably set it once and know the driver will convert it appropriately.