Remove card details if TokenCustomerID is provided.#31
Open
syanaputra wants to merge 3 commits intothephpleague:masterfrom
Open
Remove card details if TokenCustomerID is provided.#31syanaputra wants to merge 3 commits intothephpleague:masterfrom
syanaputra wants to merge 3 commits intothephpleague:masterfrom
Conversation
added 3 commits
April 2, 2019 14:13
Otherwise the card details will overwrite the displayed data. If we are only paying using token, normally we do not have expiry month and year. omnipay-eway automatically generate the month & year to be 12/99 which causes confusion on eWay dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent eWay update caused the dashboard to use credit card data that is given in the payload instead of using data from token.
By removing card details from the payload and using just TokenCustomerID, we will preserve the correct data from the token.
If we are only paying using token, normally we do not have expiry month and year.
omnipay-eway automatically generate the month & year to be 12/99 which causes confusion on eWay dashboard.