Add PB.importRoot setting and implementation#346
Add PB.importRoot setting and implementation#346jessekempf-vsco wants to merge 1 commit intothesamet:masterfrom
Conversation
|
@thesamet: Hello! What do I need to do to get this reviewed and merged? |
|
Trying to understand why the new setting is necessary - wouldn't it be possible to override |
|
@thesamet: Yes, it's possible for me to replace On the other hand, adding it as a new setting sidesteps those problems. |
|
Sorry for the delay. Can you add to the PR a test under |
We've got a protobuf repo at work we need to pull in called
protobufs, and the general structure of it looks like:And the important thing to note, here, is that this has been arranged for the convenience of Bazel. Our microservices are all written in Go with Bazel as a build tool, while our data engineering department uses Scala. We've been using Bazel and Scala so far, but I'm working on migrating away from Bazel to SBT for JVM builds.
protos/servicename2/svc2_schema.protowill import things this way:and so forth. The already-existing
sbt-protocapproach produced only protobuf errors about enum values already being defined, so I gave myself a way to directly control where to look forimports.