feat: add a view function in RoyaltiesRegistry#1284
Open
Conversation
Add a function that return the royalties without touching the storage. The previous one that has a royalty type cache is named: getRoyaltiesWithTypeCache now
feat: add a getter in the marketplace to get deductibles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a function that return the royalties without touching the storage. The previous one that has a royalty type cache is named: getRoyaltiesWithTypeCache now
Description
Brief description of the issue or feature implemented in this PR.
Link to Jira Issue or relevant doc
Dev
Any explanation for the devs that will review your implementation/code.
Qa
Any guidance or important information for the team that will be testing your solution.
Checklist and Markdown