Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 21, 2025

todo

  • test in phpunit/code-coverage
  • add unit test

With support to write into a consumer given XMLWriter tokinzer results can be consumed more efficiently, because there no longer is a DOM to XMLWriter conversion required.

@staabm staabm marked this pull request as ready for review November 22, 2025 08:48
@staabm
Copy link
Contributor Author

staabm commented Nov 25, 2025

this is good to go and a requirement for the php-code-coverage perf improvement in sebastianbergmann/php-code-coverage#1125

@staabm
Copy link
Contributor Author

staabm commented Nov 26, 2025

@theseer do you have a opinion on this one? :)

@theseer theseer merged commit de08bbb into theseer:main Dec 1, 2025
9 checks passed
@staabm staabm deleted the writer branch December 1, 2025 13:58
@theseer
Copy link
Owner

theseer commented Dec 1, 2025

@staabm After having updated a few things to get CI back working, this is now failing. I do not understand the error though. It doesn't make sense to me ;)

@theseer
Copy link
Owner

theseer commented Dec 1, 2025

PHPUnit 10.5.59 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.4.15
Configuration: /home/theseer/storage/php/tokenizer/phpunit.xml

....................E...                                          24 / 24 (100%)

Time: 00:00.030, Memory: 15.10 MB

There was 1 PHPUnit test runner warning:

1) XDEBUG_MODE=coverage (environment variable) or xdebug.mode=coverage (PHP configuration setting) has to be set

--

There was 1 error:

1) TheSeer\Tokenizer\XMLSerializerTest::testCanAppendToWriter
Error: Call to undefined method TheSeer\Tokenizer\XMLSerializer::appendToWriter()

/home/theseer/storage/php/tokenizer/tests/XMLSerializerTest.php:39

ERRORS!
Tests: 24, Assertions: 30, Errors: 1, PHPUnit Warnings: 1, PHPUnit Deprecations: 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants