Enable Refresh() to be called multiple times #701
+107
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases that demonstrate the current limitation where Refresh() can only be called once during an Updater's lifetime. - TestMultipleRefreshCalls: Tests calling Refresh() multiple times with metadata updates between calls - TestMultipleRefreshCallsNoChanges: Tests calling Refresh() multiple times when no changes are available These tests currently fail with "cannot update timestamp after snapshot" errors due to TrustedMetadata state machine restrictions. Related to theupdateframework#593 Signed-off-by: James Carnegie <[email protected]>
Allow Refresh() to be called multiple times during the lifetime of an Updater by removing workflow guards that prevented re-updating metadata after dependent metadata was loaded. The Update* methods in TrustedMetadata already handle atomic updates, version checking, and rollback protection. The guards were only needed to enforce workflow order within a single refresh cycle, but prevented multiple refresh cycles. This enables long-running processes to periodically refresh metadata without creating new Updater instances. Updates are atomic and thread-safe - metadata is never cleared, only replaced after validation. Fixes theupdateframework#593 Signed-off-by: James Carnegie <[email protected]>
kipz
force-pushed
the
kipz/multi-refresh
branch
from
fe47dfc to
12ae633
Compare
mnm678
approved these changes
Nov 17, 2025
Member
|
This has come up a few times, and has not been merged as we want to stay close to the Python implementation (where this is not allowed), and the recommended approach has been to just recreate the TUF client if that's needed. See this comment for more info: #699 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows
Refresh()to be called multiple times during an Updater's lifetime by removing workflow stateguards that prevented re-updating metadata after dependent metadata was loaded.
The
Update*methods inTrustedMetadataalready handle atomic updates, version checking, and rollbackprotection. The removed guards only enforced workflow order within a single refresh cycle but prevented
subsequent refresh cycles.
This enables long-running processes to periodically refresh metadata without creating new Updater
instances.
Relates to #593