Skip to content

replace RequestsFetcher for Urllib3Fetcher #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jku merged 13 commits into from
Feb 14, 2025
Merged

replace RequestsFetcher for Urllib3Fetcher #2762

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0675f0c
create urllib3 fetcher, replace requestsFetcher with urllibFetcher in…
NicholasTanz Jan 6, 2025
20d825f
fix line too long linting error
NicholasTanz Jan 6, 2025
031778f
more linting stuff
NicholasTanz Jan 6, 2025
18e42ce
replacing RequestsFecther with Urllib3Fetcher in .rst
NicholasTanz Jan 6, 2025
2128030
utilize one pool manager
NicholasTanz Jan 10, 2025
2aed81f
change error handling to MaxRetryError in _fetch()
NicholasTanz Jan 10, 2025
a48fca5
add retry error handling to _chunks()
NicholasTanz Jan 10, 2025
f8b1dbd
linting
NicholasTanz Jan 10, 2025
326529b
Merge branch 'theupdateframework:develop' into switchUrlLib3
NicholasTanz Jan 29, 2025
86cc7ad
clarify urllib3 as requirement in pyproject.toml and add back in requ…
NicholasTanz Jan 31, 2025
d67f126
remove self.app_user_agent attribute, as it's not used outside of init
NicholasTanz Feb 5, 2025
6318760
swap invalid urls that are used in testing. (takes care of deprecatio…
NicholasTanz Feb 12, 2025
2ac8bdc
linting
NicholasTanz Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_fetcher_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def test_fetch_in_chunks(self) -> None:
# Incorrect URL parsing
def test_url_parsing(self) -> None:
with self.assertRaises(exceptions.DownloadError):
self.fetcher.fetch("missing-scheme-and-hostname-in-url")
self.fetcher.fetch("http://invalid/")

# File not found error
def test_http_error(self) -> None:
Expand Down
2 changes: 1 addition & 1 deletion tests/test_updater_ng.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ def test_persist_metadata_fails(
def test_invalid_target_base_url(self) -> None:
info = TargetFile(1, {"sha256": ""}, "targetpath")
with self.assertRaises(exceptions.DownloadError):
self.updater.download_target(info, target_base_url="invalid_url")
self.updater.download_target(info, target_base_url="http://invalid/")

def test_non_existing_target_file(self) -> None:
info = TargetFile(1, {"sha256": ""}, "/non_existing_file.txt")
Expand Down
Loading