Conversation
| - Adding a new field, adding values to an existing enum | ||
| - **Patch**: a change which does not meaningfully alter API output - for example, bugfixes that alter incorrect behaviour to align with documented behaviour | ||
| - **Patch**: clerical changes improving spec clarity, or a change which does not meaningfully alter API output | ||
| - Correctly an inconsistency in field naming between documentation and the example of the documentation |
There was a problem hiding this comment.
The grammar in this sentence seems off
Co-authored-by: Gregor Billing <gregor.billing.dev@gmail.com>
|
Added changelog entry (no need to enumerate every change - people can check the diff if needed) and marked as Ready for Review, given that I assume you've now worked your way through the spec and its changes, so no more updates are likely? |
| | Attribute | Type | Description | | ||
| | --- | --- | --- | | ||
| | `type` | `String` | Always `percent` | ||
| | `scope` | `"single"\|"average""` | Specifies if the result should be a `single` or `average`. For ParticipationRuleset, this will always be determined by the event format, and cannot be changed via a WCIF patch.. | |
There was a problem hiding this comment.
by the round format.
Also, double full stop at the end
| | --- | --- | --- | | ||
| | `type` | `String` | Always `ranking` | ||
| | `type` | `String` | Always `ranking` | | ||
| | `scope` | `"single"\|"average""` | Specifies if the result should be a `single` or `average`. For ParticipationRuleset, this will always be determined by the event format, and cannot be changed via a WCIF patch.. | |
|
|
||
| ## Version | ||
| - Number: 2.0.0 | ||
| - Number: 2.1.1 |
There was a problem hiding this comment.
Hmm, will wca website ever request data for wcif 2.0.0 and 2.1.1?
Maybe we just support different versions based on what we intend to return from the wca website?
There was a problem hiding this comment.
Hmm, I don't quite understand this - how do you mean "Maybe we just support different versions based on what we intend to return from the wca website?"
Gregor and I chatted about this the other day - we'll basically only ever return the latest and current - so if 2.0.0 gets superceded by 2.1.1 in current, we'll cease to serve 2.0.0 - except in exceptional circumstances where we might continues to serve a deprecated version for some period of time.
3 participants
Uh oh!
There was an error while loading. Please reload this page.