-
Notifications
You must be signed in to change notification settings - Fork 200
Store JSON when submitting via WCA Live stored results #13033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Store JSON when submitting via WCA Live stored results #13033
Conversation
|
The flags around Sure, we could reuse some code here or abstract away a shared component, but the Results JSON upload is going away in a couple of weeks anyways so I didn't bother. |
|
Hmm, I think the lack of scramble storage in the WCIF will be a problem - as I presume the idea of delegates storing results is as an insurance against some kind of catastrophic data loss from the WCA's website, so us having them stored on the website because of our new scrambles matcher likely won't cut it. I do wonder if just serializing out the Results JSON isn't the best way to do this after all - we can increment the version if we need to make changes to the schema. It's either that, or adding the scramble data to the WCIF which I don't relish the prospect of because it's adding even more data to an already-bloated file. |
Not necessarily. That's only the "very very very very worst case" we're protecting against. Usually it's a matter of having a copy of the data so that WRT can "restore" certain results to their original state, or find original newcomer dates. Think about WRC or WIC first penalizing and then reinstating a solve. The first penalty would set it to |
4ebf29f to
0be1fc6
Compare
|
The mail to WRT has now been configured to include a "safety copy" of the scramble files, if the new "WCA Live sync" feature was used. If the old way (Results JSON) was used, then the scrambles are already contained in that one central "results file". So sending the separate scramble JSONs is only necessary when the new feature is being used, and I have included a code comment to explain that. |
43f8c09 to
4d8cb87
Compare
Turns out, we already had a pipeline for storing the JSONs that Delegates submit. (They get forwarded to WRT as an email attachment).
This PR connects the new "Use WCA Live results" feature to this existing pipeline, by inserting the authorized WCIF as "uploaded JSON". The point is that this contains all relevant information (persons, results) at the time of submission.
Scrambles are not included in this WCIF, but if you use "WCA Live stored results", then you have to upload scrambles to our new Scrambles Matcher anyways. They will be stored and persisted in there.