Compress the Objects send over the diff protocol#13352
Open
FinnIckler wants to merge 19 commits intothewca:mainfrom
Open
Compress the Objects send over the diff protocol#13352FinnIckler wants to merge 19 commits intothewca:mainfrom
FinnIckler wants to merge 19 commits intothewca:mainfrom
Conversation
FinnIckler
commented
Feb 6, 2026
gregorbg
requested changes
Feb 25, 2026
Member
gregorbg
left a comment
gregorbg
left a comment
There was a problem hiding this comment.
Just a bit of confusion about the type hierarchy still... Otherwise looking good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also removes sending over local_pos and global_pos. I tried giving the values that will be send over the most the shortest names.
I have not done tie handling yet in the order by (I mean I have, but not in the mapping them to their positions)