Skip to content

Remove valueN columns from Results#13486

Open
gregorbg wants to merge 11 commits intothewca:mainfrom
gregorbg:feature/byebye-valueN
Open

Remove valueN columns from Results#13486
gregorbg wants to merge 11 commits intothewca:mainfrom
gregorbg:feature/byebye-valueN

Conversation

@gregorbg
Copy link
Member

This removes the last bit of dependencies we had on valueN: The attempt lists in Rankings and Records pages.

The idea for augmenting the data is courtesy of @FinnIckler, although I'm not entirely sure yet whether we should do the augmentation frontend- or backend-sided. I went with frontend for the time being, although this does pose challenges for the new NextJS frontend where caching works a tad bit different...

@gregorbg gregorbg force-pushed the feature/byebye-valueN branch from f607b68 to 23b7138 Compare February 22, 2026 08:21
@gregorbg gregorbg marked this pull request as ready for review February 22, 2026 08:41
@gregorbg
Copy link
Member Author

I went with augmentation in the backend instead, to facilitate sharing the logic between legacy React and NextJS.

Also, I noticed that the "many" test cases where we do update!(valueN: 123) are actually just four or five instances, all of them in the results_validators and all of them can be replaced with merging the updates into the instantiation. So yay, one less hacking hook 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant