Begin uploading results to matched_scrambles#13934
Open
gregorbg wants to merge 16 commits intothewca:mainfrom
Open
Begin uploading results to matched_scrambles#13934gregorbg wants to merge 16 commits intothewca:mainfrom
matched_scrambles#13934gregorbg wants to merge 16 commits intothewca:mainfrom
Conversation
48a330f to
9f8b6b7
Compare
9f8b6b7 to
9c6ac3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR eases in the migration path towards the integrated Scrambles Matcher.
We currently hard-upload every scramble to the productive, public
Scramblestable directly, right at the moment that the Delegate uploads the results JSON. This is really as awkward as it sounds.With the work on integrating scrambles matcher, we now suddenly have matchup tables that can serve as a suitable replacement for temporary scramble posting, kinda like a smarter version of
inbox_scrambles.However, in order to not disturb existing results posting procedures, we need to smoothly "ease in" the new data flow. So this PR does the following:
scramblesdirectly) AND it also uploads tomatched_scramblesin the background.matched_scramblesis not used productively (yet), it's just silently being writtenmatched_scrambles, and also stops uploading to the publicscramblestable upon upload.This procedure is mostly necessary in order to not disturb any ongoing submissions that are either pending or in the process of being posted while this PR is being deployed.