Conversation
| function parseActivityCodeOrNull(path: string) { | ||
| try { | ||
| const { eventId } = parseActivityCode(path); | ||
| return eventId; | ||
| } catch { | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
Nope. No try-catch. Not at all.
What is causing parseActivityCode to raise an exception and how can we detect these edge cases before passing the data into parseActivityCode?
| height="fit-content" | ||
| position="sticky" | ||
| minWidth="fit-content" | ||
| width="3xs" |
There was a problem hiding this comment.
Why did the previous not work? I think min-width makes a lot of sense with respect to "making sure that long tab titles still at least fit the darn thing", perhaps you want to assing a max-width separately?
There was a problem hiding this comment.
It's because the content size changes when you open the submenus. So the UI gets jumpy. max-width doesn't change anything here
| <Text | ||
| textStyle="bodyEmphasis" | ||
| asChild | ||
| maxW="44" |
There was a problem hiding this comment.
Where did this magical constant come from? I know it is defined in Chakra, but why did you choose it?
There was a problem hiding this comment.
This is from the previous version of the menu code that I accidentally deleted. I think it was the most fitting option for custom tabs
2 participants
parseActivityCodeOrNullfunction. Ideas welcome