Skip to content

ILR AddResults fixes#14056

Open
FinnIckler wants to merge 5 commits intothewca:mainfrom
FinnIckler:addResults-fixes
Open

ILR AddResults fixes#14056
FinnIckler wants to merge 5 commits intothewca:mainfrom
FinnIckler:addResults-fixes

Conversation

@FinnIckler
Copy link
Copy Markdown
Member

@FinnIckler
Copy link
Copy Markdown
Member Author

Now also fixes #13790 because I had the math the wrong way around

Copy link
Copy Markdown
Member

@gregorbg gregorbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not quite follow your open and onOpenChange logic. Especially the X and Y coordinates raise a flag in my brain -- this is suff that should normally be abstracted away behind components.

If you want a table, you just say "draw a table with these rows and columns, and then add grid lines between the rows". You don't say (explicitly, as the programmer) "please draw a horizontal line from X=... and Y=... to X=... and Y=...".

@FinnIckler
Copy link
Copy Markdown
Member Author

That is not what I am doing.
Chakra Menu component except a rect where to draw the menu as the positioning argument. Because I want to draw the menu anywhere on the row I pass in the X and Y argument as part of the on click event. This is supported behaviour of the menu component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants