Open
Conversation
Member
FinnIckler
commented
Apr 15, 2026
FinnIckler
commented
- adds an empty message like in WCA Live
- Groups them together and fixes Group "To be determined" podiums together, the way old WCA Live does it #13780
- Fixes the background issue of /live/podiums tables UI improvement #13903
gregorbg
requested changes
Apr 19, 2026
Comment on lines
+82
to
+89
| {eventsNotFinished.map((finalRound) => { | ||
| const { eventId } = parseActivityCode(finalRound.id); | ||
| return ( | ||
| <Text p="2" key={eventId}> | ||
| {events.byId[eventId].name} | ||
| </Text> | ||
| ); | ||
| })} |
Member
There was a problem hiding this comment.
What is this mapped list of Texts supposed to be?
- A bullet list? Then use
Listto wrap it. - A stack? Then use
Stackto wrap it. - Something else? Then use another appropriate component to wrap it.
| })} | ||
| {!noPodiums && eventsNotFinished.length > 0 && ( | ||
| <> | ||
| <Heading textStyle="h3" p="2"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.