Move Attemptsfield to components and minor clean up#14059
Open
FinnIckler wants to merge 3 commits intothewca:mainfrom
Open
Move Attemptsfield to components and minor clean up#14059FinnIckler wants to merge 3 commits intothewca:mainfrom
FinnIckler wants to merge 3 commits intothewca:mainfrom
Conversation
gregorbg
reviewed
Apr 19, 2026
| if (number === SKIPPED_VALUE) return ""; | ||
| if (number === DNF_VALUE) return "DNF"; | ||
| if (number === DNS_VALUE) return "DNS"; | ||
| const SPECIAL_VALUES: Partial<Record<number, string>> = { |
Member
There was a problem hiding this comment.
Why is it Partial? You could declare type SpecialValue = SKIPPED_VALUE | DNF_VALUE | DNS_VALUE or something, and roll with that.
But anyways, isn't Record inherently partial? If I declare a Record<string, something>, then I don't have to map every single string in existence...
Comment on lines
+64
to
+66
| Object.fromEntries( | ||
| Object.entries(SPECIAL_VALUES).map(([k, v]) => [v, Number(k)]), | ||
| ) as Partial<Record<string, number>>; |
Member
There was a problem hiding this comment.
Is there a Lodash helper for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am pretty happy with the existing API, just moved the 4 repeating ifs to a record