Add spacing in message and button in header on Newcomers Check page#14076
Add spacing in message and button in header on Newcomers Check page#14076pranav-027 wants to merge 1 commit intothewca:mainfrom
Conversation
| {NEWCOMER_COUNT_THRESHOLD} | ||
| ), it may be possible that your job actually needs more time to run. | ||
| Please use the button at your own discretion. | ||
| {' '} |
There was a problem hiding this comment.
@coder13 Can you please let us know if this the right way to add spacing or do you have any other idea?
@kr-matthews Looking for input from you too.
There was a problem hiding this comment.
Hello @danieljames-dj ,
You can check the lines 40, 42, and 46 in the same file. Same approch has been used to add spaces
There was a problem hiding this comment.
DM me if you want feedback for PRs. I happened to randomly click on this one.
It's not a terrible method, I do it.
But a stronger way, if you actually want padding and not a space, is to use css like margin / padding / gap. You can use gap for elements configured as "flex".
There was a problem hiding this comment.
@pranav-027 in the lines you mentioned, the purpose was to have a space between two texts, and for which using the standard space is the way to go.
But here the requirement is bit different - we are trying to add space between the text and the button which should be ideally done with css like the ones Cailyn mentioned.
Though css will work, I don't know if it's a react-sem-ui way of doing it. But if there are no other solutions, css should be good. Or even the space that you suggested.
@gregorbg looking for your feedback.
3 participants
fixes: #13996