Add argument parsing for triangle/circumcircle to improve coverage#92
Open
dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
Open
Add argument parsing for triangle/circumcircle to improve coverage#92dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
dgtized wants to merge 1 commit intothi-ng:feature/no-orgfrom
Conversation
Handles receiving a triangle, a map with points a,b,c and a sequential tuple of three elements. Also adds tests to cover these cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handles receiving a triangle, a map with points a,b,c and a sequential tuple of
three elements.
Also adds tests to cover these cases.
This allows constructions like
(map t/circumcircle triangles)to work as expected instead of throwing errors around missing keys a,b,c.However on the API design front, I'm a little hesitant about the use of
instance?. I wonder ifthi.ng.geom.coreneeds aICircumcircleprotocol, and not just the protocol with a bounding circle? It's also not clear how to handle this if the argument is a Triangle3 at this time?