🔧 Add LDFLAGS after object files to Makefile

[jwir3]

I was getting an issue where ld could not find a reference to the cairo
functions. It was caused by the -lcairo flag being passed BEFORE the
main.o, pla.o, etc... to g++.

[ghost]

Hi. Sory for the delay, I do not receive notification for pull requests.

I think that the main error is not the position of LDFLAGS, but the abscence of LDLIBS.

Makefile use this command:

$(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@

I suggest the addition of the variable LDLIBS

[jwir3]

Sure, I can make that change. I'm actually in the process of separating pla into a main c file and an associated library (that builds to a .so) file. Would this be something you're interested in having in the upstream repo, or should I just keep it in my branch? ~Scott

…

On Sat, Dec 7, 2019, 11:25 AM OZON ***@***.***> wrote: Hi. Sory for the delay, I do not receive notification for pull requests. I think that the main error is not the position of LDFLAGS, but the abscence of LDLIBS. Makefile use this command: $(CC) $(LDFLAGS) $^ $(LDLIBS) -o $@ I suggest the addition of the variable LDLIBS — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2?email_source=notifications&email_token=AAHTN4X5VSELIQ6B4EVGWDDQXPMCBA5CNFSM4JTHYNC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGLPIQ#issuecomment-562870178>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHTN4T3HKFPLX4OQHHAG23QXPMCBANCNFSM4JTHYNCQ> .