-
Notifications
You must be signed in to change notification settings - Fork 9
feat: complex / combine measurements #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reubenmiller
merged 4 commits into
thin-edge:main
from
wilbersl:feat-combine-measurements
Sep 12, 2025
Merged
feat: complex / combine measurements #31
reubenmiller
merged 4 commits into
thin-edge:main
from
wilbersl:feat-combine-measurements
Sep 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for this PR, as well! I think the feature makes sense - I was looking into leveraging bulk creation of Measurements, but this makes also sense for a lot of use cases. |
Collaborator
|
Seems good to me |
reubenmiller
reviewed
Sep 9, 2025
Robot Results
Passed Tests
|
reubenmiller
approved these changes
Sep 12, 2025
Contributor
reubenmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilbersl Approved. Thanks again for the nice addition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This pull request introduces the creation of complex / combined Measurements to the Modbus plugin, designed to reduce unnecessary data traffic to the cloud. These changes enable users to prioritize high-volume data cloud resource usage for static or infrequently changing data points. This Feature works hand in hand with the
on-changekeyword to ensure sending fewer measurements with only the needed data.Motivation
I use thin-edge with my own modbus poller and complex / combined measurements for some time now and want to switch to the official plugin.
Inline with my issue
Features Implemented
The feature generally opt-in, devices who currently use this plugin won't change their behavior. It can be activated on a global level as well as on a per device level, opt-out is also possible per Device.
How it Works: The plugin checks for an optional
combinemeasuermentskey within the modbus configuration or a device's configuration in the modbus.toml / devices.toml file. When generating the measurements this Key is checked in the Priority 1st Device | 2nd Global . If it is absent in the device, the plugin falls back to the global and if it is absent there it's off, ensuring full backward compatibility.Example Configurations
Test
modbus.tomlwith feature active:Test
devices.tomlcan still be used to opt-out single devices: