fix: define a start command to avoid restarting the tedge-agent on a reconnect#140
Merged
reubenmiller merged 1 commit intomainfrom Jun 4, 2025
Merged
Conversation
reubenmiller
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
didier-wenzek
approved these changes
Jun 4, 2025
rina23q
approved these changes
Jun 4, 2025
Member
rina23q
left a comment
rina23q
left a comment
There was a problem hiding this comment.
Looks good.
From the history, it seems very first version of implementation (4 years ago) didn't have start definition. start was added later 2 years ago. So, probably it was missing because of the change...
Robot Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thin-edge.io init system definition file (
system.toml) did not have a "start" method defined, which led to the restart command being used by default.Adding an explicit "start" command avoids unexpected restarts of teh tedge-agent when running
tedge reconnect c8y.