Skip to content

fix: Disable partial download if file being downloaded is modified between retries #3941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bravo555 merged 4 commits into from
Feb 2, 2026
+948 −616
Merged

fix: Disable partial download if file being downloaded is modified between retries #3941

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b78bd41
refactor(download): split tests to other file
Bravo555 Jan 23, 2026
7d4a43d
refactor(download): remove duplication in retry logic
Bravo555 Jan 23, 2026
f19a5d0
fix(download): verify etags for resumed requests
Bravo555 Jan 23, 2026
a7763e4
fix(download): Truncate file after finishing download
Bravo555 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions crates/common/download/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ repository = { workspace = true }
anyhow = { workspace = true, features = ["backtrace"] }
backoff = { workspace = true }
certificate = { workspace = true, features = ["reqwest"] }
http = { workspace = true }
hyper = { workspace = true }
log = { workspace = true }
nix = { workspace = true }
Expand Down
Loading