Skip to content

test: reduce flakiness of system test: Order of flow definition updates does not matter#4014

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-improve-flow-order-updates
Feb 27, 2026
Merged

test: reduce flakiness of system test: Order of flow definition updates does not matter#4014
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:test-improve-flow-order-updates

Conversation

@reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Feb 26, 2026

Proposed changes

Improve the "Order of flow definition updates does not matter" system test to reduce the flakiness.

flake-finder report

Before

$ invoke flake-finder --suite "tedge_flows" --iterations 20 --clean
------------------------------
Overall: FAILED
Results: 20 iterations, 14 passed, 6 failed
Elapsed time: 0:23:02.111119
Failed iterations: [1, 3, 5, 9, 10, 16]

After

$ invoke flake-finder --suite "tedge_flows" --iterations 20 --clean
------------------------------
Overall: PASSED
Results: 20 iterations, 20 passed, 0 failed
Elapsed time: 0:23:23.797479

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

The following runs observed an error.

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2026

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
843 0 3 843 100 2h41m28.124208999s

@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added skip-release-notes Don't include the ticket in the auto generated release notes flaky test Label given to flaky or otherwise faulty tests labels Feb 27, 2026
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Feb 27, 2026
Merged via the queue into thin-edge:main with commit f2e0578 Feb 27, 2026
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flaky test Label given to flaky or otherwise faulty tests skip-release-notes Don't include the ticket in the auto generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants