Conversation
|
Dear @brendanmckeown , I added you as a reviewer because Raymond here (a new member of the Comcast Corporate team) mentioned that he had some observations about this repo, and I told him "by all means, submit a pull request." So here is that pull request! Do you think there is someone else that should get this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm script is broken and gives an error when you try running it on you local environment.
Error Message when running npm start:
It looks like we are on
"webpack-cli": "^4.1.0",, which now requires an updated command fornpm startto work properly.The fix was to change the following in package.json:
to