Fix nan issue for certain shape#10
Open
hebiao064 wants to merge 1 commit intothinking-machines-lab:mainfrom
Open
Fix nan issue for certain shape#10hebiao064 wants to merge 1 commit intothinking-machines-lab:mainfrom
hebiao064 wants to merge 1 commit intothinking-machines-lab:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that for certain shape such as (32, 128) * (128, 1024), if we replace
aten::mmwithmatmul_persistent, the output would consist NaN hence generate gibberish output from LLMs.I tried to fixed in by removing the dual pipeline logic(?) and it should work.
I've also tested with more shapes combination here: https://github.com/sgl-project/sglang/pull/11368/files#diff-fc88db1a639b98e0e4cceb66f72842a1612290664ba6753ad6f54d8276e0cd6aR88-R131