Fix: Prevent multiple decimal errors in input calculator #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi 👋, please review this PR whenever possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
A decimal was only permitted by the logic if there were no dots in the entire input.
For instance, after typing
3.5 +, it was not possible to enter another decimal, such as2.4.What's fixed?
Decimal validation has been updated to: - Permit one decimal per number segment - Prevent multiple decimals in the same number - Maintain current functionality
Tested: (Correctly blocked) single number multiple decimals
Multi-number decimals ✔ (Working) - Decimals + mixed operations ✔
This fix enhances the calculator's accuracy and usability without changing its fundamental functionality.
