Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Jan 28, 2025

PR-Codex overview

This PR focuses on enhancing the ThirdwebContract class by changing internal properties to public, adding new data structures for session keys and wrapped calls, and introducing methods for generating signatures and typed data definitions in the EngineWallet class.

Detailed summary

  • Changed properties in ThirdwebContract from internal to public.
  • Added SessionKeyParams_7702, Call, and WrappedCalls classes for handling session keys and wrapped calls.
  • Introduced GenerateSignature_SmartAccount_7702_WrappedCalls and GenerateSignature_SmartAccount_7702 methods in EIP712.cs.
  • Added typed data definitions for session keys and wrapped calls.
  • Implemented EngineWallet class with methods for transaction handling and signing messages.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 4.05405% with 284 lines in your changes missing coverage. Please review.

Project coverage is 68.96%. Comparing base (869e48c) to head (54b1739).

Files with missing lines Patch % Lines
...dweb/Thirdweb.Wallets/EngineWallet/EngineWallet.cs 0.00% 236 Missing ⚠️
Thirdweb/Thirdweb.Wallets/EIP712.cs 0.00% 36 Missing ⚠️
...SmartWallet/Thirdweb.AccountAbstraction/AATypes.cs 0.00% 11 Missing ⚠️
Thirdweb/Thirdweb.Utils/Utils.cs 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   72.69%   68.96%   -3.73%     
==========================================
  Files          34       35       +1     
  Lines        5233     5520     +287     
  Branches      693      724      +31     
==========================================
+ Hits         3804     3807       +3     
- Misses       1254     1537     +283     
- Partials      175      176       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit c58f47a into main Feb 21, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/7702-hackathon branch February 21, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants