Skip to content

Fix NFTMetadata.QuantityOwned for ERC1155 #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix NFTMetadata.QuantityOwned for ERC1155 #127

merged 2 commits into from
Feb 7, 2025

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 7, 2025 •
edited by pr-codex bot
Loading

Fixes TOOL-3341

PR-Codex overview

This PR focuses on improving error handling and code clarity in the ThirdwebExtensions.cs file and commenting out test cases in Thirdweb.AI.Tests.cs.

Detailed summary

  • Enhanced error handling by adding checks for ownerAddresses and tokenIds length in ThirdwebExtensions.cs.
  • Updated variable names for clarity, changing ownerNftTasks to ownedNftTasks and adding ownedBalances.
  • Commented out multiple test methods in Thirdweb.AI.Tests.cs to disable them.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 7, 2025

TOOL-3341 Wrong quantity owned for erc1155

@0xFirekeeper 0xFirekeeper merged commit 93191be into main Feb 7, 2025
2 of 3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/quant-owned-fix branch February 7, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xFirekeeper