Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Feb 28, 2025

Closes TOOL-3568


PR-Codex overview

This PR focuses on enhancing the NFT and token handling in the Thirdweb library by introducing new properties, methods, and modifying existing structures to support additional metadata and better serialization.

Detailed summary

  • Changed Data property type in RpcError from string to object.
  • Added VideoUrl property to NFTMetadata.
  • Introduced ToNFT and ToNFTList extension methods in ThirdwebInsightExtensions.
  • Updated GetTokens methods to include withMetadata parameter.
  • Added pagination parameters (limit, page) to GetTokens_ERC20, GetTokens_ERC721, and GetTokens_ERC1155.
  • Created new classes for Meta, NFT_ExtraMetadata, NFT_Collection, and NFT_Contract.
  • Updated serialization attributes across multiple classes to enhance JSON handling.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Feb 28, 2025

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 4.59770% with 83 lines in your changes missing coverage. Please review.

Project coverage is 65.61%. Comparing base (a65e8c0) to head (ddc1133).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Indexer/ThirdwebInsight.Types.cs 0.00% 38 Missing ⚠️
...web/Thirdweb.Indexer/ThirdwebInsight.Extensions.cs 0.00% 33 Missing ⚠️
Thirdweb/Thirdweb.Indexer/ThirdwebInsight.cs 0.00% 10 Missing ⚠️
Thirdweb/Thirdweb.RPC/ThirdwebRPC.cs 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #135      +/-   ##
==========================================
- Coverage   66.24%   65.61%   -0.63%     
==========================================
  Files          37       38       +1     
  Lines        5747     5814      +67     
  Branches      748      753       +5     
==========================================
+ Hits         3807     3815       +8     
- Misses       1764     1823      +59     
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@0xFirekeeper 0xFirekeeper merged commit 51dffbe into main Feb 28, 2025
3 checks passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/insight-nft branch February 28, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants