Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 2, 2024

Support current and future zk chains automatically


PR-Codex overview

This PR focuses on enhancing the Utils class to support asynchronous operations and improve the handling of zkSync chain data across various components in the Thirdweb library.

Detailed summary

  • Added a new test method FetchThirdwebChainDataAsync_ReturnsStack_WhenResponseIsSuccessful to validate successful responses.
  • Updated IsZkSync method to be asynchronous and include additional chain ID checks.
  • Modified multiple classes to call the asynchronous IsZkSync method.
  • Adjusted logic in GetChainMetadata to handle null or empty explorers.
  • Ensured consistent use of asynchronous calls when checking for zkSync across ThirdwebTransaction and SmartWallet classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@0xFirekeeper 0xFirekeeper merged commit f62c6b0 into main Oct 3, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/chaindb-stack branch October 3, 2024 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants