Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 2, 2024

Improve dx, less casting requirements
Also removes the need to call SmartWallet.GetPersonalWallet to fetch linked accounts or link new ones with its signer


PR-Codex overview

This PR focuses on enhancing the account linking functionality across various wallet implementations in the Thirdweb library. It introduces new methods for linking accounts and retrieving linked accounts while updating existing methods to support a more generalized wallet interface.

Detailed summary

  • Added LinkAccount and GetLinkedAccounts methods to IThirdwebWallet.
  • Implemented LinkAccount and GetLinkedAccounts methods in SmartWallet.
  • Updated LinkAccount in InAppWallet and EcosystemWallet to accept IThirdwebWallet.
  • Added validation for wallet types in SmartWallet and updated error handling.
  • Enhanced argument checks in LinkAccount methods across wallet classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Improve dx, less casting requirements
@0xFirekeeper 0xFirekeeper merged commit 17f87c5 into main Oct 2, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/expose-linking branch October 2, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants