Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 24, 2024

PR-Codex overview

This PR focuses on enhancing the Read method in the ThirdwebContract class to support decoding results into List<object> and arrays, along with adding two new test cases to verify this functionality.

Detailed summary

  • Added two test methods: ReadTest_TupleIntoArray and ReadTest_TupleIntoList to verify reading results into lists and arrays.
  • Enhanced the Read method to handle decoding results into List<object> and arrays.
  • Implemented JSON serialization and deserialization for output results.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@0ccfbca). Learn more about missing BASE report.

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Contracts/ThirdwebContract.cs 86.36% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage        ?   78.25%           
=======================================
  Files           ?       28           
  Lines           ?     4360           
  Branches        ?      612           
=======================================
  Hits            ?     3412           
  Misses          ?      784           
  Partials        ?      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 07da310 into main Oct 24, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/list-array-tuple-return branch October 24, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants