Skip to content

Conversation

@0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 7, 2024

PR-Codex overview

This PR enhances the GenerateDataKey method in the AWS.cs file by adding an optional dateOverride parameter. This allows for custom date handling when generating a data key, improving error handling related to signature validation.

Detailed summary

  • Added an optional dateOverride parameter to the GenerateDataKey method.
  • Modified the date handling to use dateOverride if provided; otherwise, it defaults to DateTime.UtcNow.
  • Introduced a new format string for amzDate.
  • Added error handling to retry the data key generation with a parsed date from the response if an InvalidSignatureException occurs.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (65107c5) to head (a80dade).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #95   +/-   ##
=======================================
  Coverage   78.17%   78.17%           
=======================================
  Files          28       28           
  Lines        4358     4358           
  Branches      610      610           
=======================================
  Hits         3407     3407           
  Misses        787      787           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit d4be241 into main Nov 7, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/system-time-fallback branch November 7, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants