chore: Require HTTPS webhook URLs #745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Oct 30, 2024
src/server/utils/validator.ts
Outdated
| const url = new URL(urlString); | ||
| return url.protocol === "http:" || url.protocol === "https:"; | ||
| const url = new URL(input); | ||
| return url.protocol === "https:"; |
Contributor
Author
There was a problem hiding this comment.
removes http: as a valid protocol
Contributor
There was a problem hiding this comment.
can we still allow 0.0.0.0/127.0.0.1 and localhost?
Contributor
Author
There was a problem hiding this comment.
Yeah I think this is reasonable.
d4mr
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating the webhook functionality to enforce stricter URL validation and improve the clarity of webhook-related code. It renames functions and modifies schemas to ensure only valid HTTPS URLs are accepted.
Detailed summary
activeproperty assignment inwebhook.tsto simplify logic.isValidHttpUrltoisValidWebhookUrlinvalidator.ts.addContractSubscription.tsto use the newisValidWebhookUrlfunction.createWebhooktocreateWebhookRoutein route files.create.tsto reflect new validation rules.isValidWebhookUrlinvalidator.test.ts.