Skip to content

fix getWalletDetails to fallback awsKmsAccessKeyId instead of awsKmsKeyId #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix getWalletDetails to fallback awsKmsAccessKeyId instead of awsKmsKeyId #776

merged 1 commit into from
Nov 19, 2024

Conversation

@d4mr
Copy link
Contributor

@d4mr d4mr commented Nov 19, 2024 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR focuses on renaming a property in the walletDetails object from awsKmsKeyId to awsKmsAccessKeyId, ensuring consistency in naming conventions related to AWS credentials.

Detailed summary

  • Changed the property walletDetails.awsKmsKeyId to walletDetails.awsKmsAccessKeyId.
  • Updated the assignment for walletDetails.awsKmsAccessKeyId to include a fallback to config.walletConfiguration.aws?.awsAccessKeyId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@d4mr d4mr merged commit 39f1fc2 into main Nov 19, 2024
5 checks passed
@d4mr d4mr deleted the pb/fix-aws-kms-access-key-id branch November 19, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d4mr