Skip to content

Conversation

@dirtycajunrice
Copy link
Contributor

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)

Copy link
Contributor Author

dirtycajunrice commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dirtycajunrice dirtycajunrice marked this pull request as ready for review December 10, 2024 22:14
Copy link
Contributor

@arcoraven arcoraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why every file's whitespace got changed. Is this intended or expected?

// Allow this request to proceed.
return;
} else if (error) {
}if (error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be newlines

@dirtycajunrice dirtycajunrice enabled auto-merge (squash) December 12, 2024 00:19
@dirtycajunrice dirtycajunrice merged commit 0a8c39f into main Dec 12, 2024
4 of 6 checks passed
@dirtycajunrice dirtycajunrice deleted the 12-10-regenerate_sdk branch December 12, 2024 00:28
arcoraven added a commit that referenced this pull request Dec 31, 2024
Co-authored-by: Phillip Ho <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>
arcoraven added a commit that referenced this pull request Dec 31, 2024
* regenerate sdk (#808)

Co-authored-by: Phillip Ho <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

* bump sdk version (#813)

Signed-off-by: Phillip Ho <[email protected]>

* update workflow action versions (#812)

Signed-off-by: Phillip Ho <[email protected]>

* fix all biome errors (#815)

* bump yarn to berry

* fix all biome errors

* bring back pinned resolved deps, fix whitepsace

---------

Co-authored-by: Phillip Ho <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

* get-balance and get-all-events migrated to v5 (#816)

Signed-off-by: Phillip Ho <[email protected]>

* thirdweb version bump (#818)

thirdweb sdk version bump to v5.78.0

Signed-off-by: Phillip Ho <[email protected]>

* chore: fix some typos in comment

Signed-off-by: toofooboo <[email protected]>
Signed-off-by: Phillip Ho <[email protected]>

---------

Signed-off-by: Phillip Ho <[email protected]>
Signed-off-by: toofooboo <[email protected]>
Co-authored-by: Nicholas St. Germain <[email protected]>
Co-authored-by: Nischit Prasad Nhuchhe Pradhan <[email protected]>
Co-authored-by: toofooboo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants