-
Notifications
You must be signed in to change notification settings - Fork 105
V5 migration of get-balance (native) and get-all-events api #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| const returnData = mapEventsV4ToV5( | ||
| await getContractEvents({ | ||
| contract: contract, | ||
| fromBlock: BigInt(fromBlock), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript error here.
I think we should update the querystring schema here to be int | undefined only, and here use maybeBigInt(fromBlock) which maps a number | undefined type to bigint | undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fromBlock: maybeBigInt(fromBlock?.toString()) instead but keeping it unresolved to make sure its done correctly
45b9d08 to
8dd2de0
Compare
* bump yarn to berry * fix all biome errors * bring back pinned resolved deps, fix whitepsace --------- Co-authored-by: Phillip Ho <[email protected]>
686afe0 to
a7b8d01
Compare
Pull request was closed
Unit tests are created for compairing v4 and v5 outputs.
I'll need some basic help with Typescript types. I've only made jsdoc comments to explain the function parameters.
APIs migrated
PR-Codex overview
This PR primarily focuses on code quality improvements, including type adjustments, error handling enhancements, and updates to logging messages. It also includes some updates to dependencies and modifications to the way certain functions are structured.
Detailed summary
text=autoto.gitattributes._einstead ofein multiple files.typekeyword where applicable.unknowninstead ofany.package.jsonversion for@thirdweb-dev/engine.constinstead ofletwhere possible._reqinstead ofreqin various routes.testWebhookmethod inWebhooksService.