fix: /reset-nonces endpoint allows deleting nonce state without resyncing #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcoraven
commented
Jan 25, 2025
| /** | ||
| * Stores a list of onchain vs sent nonces to check if the nonce is stuck over time. | ||
| */ | ||
| export function nonceHistoryKey(chainId: number, walletAddress: Address) { |
Contributor
Author
There was a problem hiding this comment.
Just swapping the args to match the patterns of the others
arcoraven
commented
Jan 25, 2025
| lastUsedNonceKey(chainId, walletAddress), | ||
| recycledNoncesKey(chainId, walletAddress), | ||
| sentNoncesKey(chainId, walletAddress), | ||
| nonceHistoryKey(chainId, walletAddress), |
Contributor
Author
There was a problem hiding this comment.
Also delete nonce history when we reset nonces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR introduces enhancements to nonce management in the wallet system, including the addition of a nonce history tracking feature and adjustments to the backend wallet nonce reset functionality.
Detailed summary
nonceHistoryKeyfunction to track onchain vs sent nonces.deleteNoncesForBackendWalletsto include nonce history key.resetBackendWalletNoncesRouteto includesyncOnchainNoncesparameter.RESYNC_BATCH_SIZEtoBATCH_SIZE.syncOnchainNoncesflag.