Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Mar 6, 2025

PR-Codex overview

This PR enhances the addContractSubscription functionality by introducing a new optional webhookId parameter, allowing users to either specify an existing webhook or create a new one using a webhookUrl. It improves error handling and ensures proper webhook management.

Detailed summary

  • Added shortenAddress import from thirdweb/utils.
  • Introduced webhookId as an optional parameter in the request body schema.
  • Implemented logic to retrieve an existing webhook or create a new one based on webhookId or webhookUrl.
  • Enhanced error handling for webhook retrieval/creation.
  • Updated createContractSubscription to use the determined webhookId.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zeet-co
Copy link

zeet-co bot commented Mar 6, 2025

engine-cloud - engine-cloud-dev

We're building your pull request over Zeet. We have provided links for Zeet apps linked to this github repo

Application Name Dashboard Link Preview Link
engine-cloud-core-dev Go to App in Zeet Console Preview App
engine-v3-test-instance Go to App in Zeet Console Preview App

@zeet-co
Copy link

zeet-co bot commented Mar 6, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-ph-att-e800b8.engine-aws-usw2.zeet.app before merging 😉

@arcoraven arcoraven merged commit 8f59c2e into main Mar 6, 2025
5 of 6 checks passed
@arcoraven arcoraven deleted the ph/attach-existing-webhook branch March 6, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants