Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 19, 2025

Changes

How this PR will be tested

  • Open the dashboard and click X. Result: A modal should appear.
  • Call the /foo/bar API. Result: Returns 200 with "baz" in the response body.

Output

(Example: Screenshot/GIF for UI changes, cURL output for API changes)


PR-Codex overview

This PR focuses on enhancing transaction handling and data signing in the backend, particularly with smart wallets and transaction overrides. It introduces new types, improves error handling, and refines transaction preparation and queuing.

Detailed summary

  • Updated src/shared/utils/transaction/types.ts to import and define types.
  • Enhanced src/server/routes/contract/write/write.ts to better handle transaction overrides.
  • Modified src/server/routes/backend-wallet/sign-typed-data.ts to include chainId and primaryType in the request body, improving smart wallet handling.
  • Updated signing logic to use account.signTypedData.
  • Refined transaction preparation in src/server/routes/backend-wallet/send-transaction.ts, integrating overrides and simplifying transaction queuing.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zeet-co
Copy link

zeet-co bot commented Mar 19, 2025

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-refact-83240f.engine-aws-usw2.zeet.app before merging 😉

@zeet-co
Copy link

zeet-co bot commented Mar 19, 2025

engine-cloud - engine-cloud-dev

We're building your pull request over Zeet. We have provided links for Zeet apps linked to this github repo

Application Name Dashboard Link Preview Link
engine-cloud-core-dev Go to App in Zeet Console Preview App
engine-v3-test-instance Go to App in Zeet Console Preview App

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Refactor transaction handling with prepareTransaction and queueTransaction Refactor send-transaction and sign typed data to v5 Mar 19, 2025
@joaquim-verges joaquim-verges force-pushed the Refactor_transaction_handling_with_prepareTransaction_and_queueTransaction branch from f56d319 to 9965eb2 Compare March 19, 2025 20:20
@joaquim-verges joaquim-verges merged commit d614d18 into main Mar 19, 2025
8 checks passed
@joaquim-verges joaquim-verges deleted the Refactor_transaction_handling_with_prepareTransaction_and_queueTransaction branch March 19, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants